From 9ac060a1dae68cbaa92d43e87b441dc98acc4808 Mon Sep 17 00:00:00 2001
From: Natsu <natsume@natsume.io>
Date: Sat, 6 Jul 2024 14:11:10 +0700
Subject: [PATCH] chore(build.yml): update sign-android-release action to use
 r0adkll/sign-android-release@v1 feat(build.yml): update upload-artifact
 action to use actions/upload-artifact@v3 feat(build.yml): remove send
 notification to Discord step

---
 .github/workflows/build.yml | 25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 00bf7e5..43d4175 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -44,38 +44,31 @@ jobs:
       run: ./gradlew build
 
     - name: Sign APK
-      uses: ilharp/sign-android-release@v1
+      uses: r0adkll/sign-android-release@v1
       id: sign_app
       with:
-        releaseDir: app/build/outputs/apk/debug
-        signingKey: ${{ secrets.KEYSTOREB64 }}
-        keyAlias: ${{ secrets.ANDROID_KEY_ALIAS }}
+        releaseDirectory: app/build/outputs/apk/release
+        signingKeyBase64: ${{ secrets.KEYSTOREB64 }}
+        alias: ${{ secrets.ANDROID_KEY_ALIAS }}
         keyStorePassword: ${{ secrets.ANDROID_KEYSTORE_PASSWORD }}
         keyPassword: ${{ secrets.ANDROID_KEY_PASSWORD }}
-        buildToolsVersion: 34.0.0
+      env:
+        BUILD_TOOLS_VERSION: "34.0.0"
       continue-on-error: true
 
     - name: Rename Signed APK
       run: |
         branch=$(git rev-parse --abbrev-ref HEAD)
         hash=$(git rev-parse --short=7 HEAD)
-        mv ${{steps.sign_app.outputs.signedFile}} app/build/outputs/apk/debug/Gakumas-Localify-EN_$branch.$hash.apk
-        echo "SIGNED_APK=app/build/outputs/apk/debug/Gakumas-Localify-EN_$branch.$hash.apk" >> $GITHUB_ENV
+        mv ${{steps.sign_app.outputs.signedReleaseFile}} app/build/outputs/apk/release/Gakumas-Localify-EN_$branch.$hash.apk
+        echo "SIGNED_APK=app/build/outputs/apk/release/Gakumas-Localify-EN_$branch.$hash.apk" >> $GITHUB_ENV
 
     - name: Upload Artifact
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v3
       with:
         name: Gakumas-Localify-EN
         path: ${{ env.SIGNED_APK }}
 
-    - name: Send Notification to Discord
-      uses: sarisia/actions-status-discord@v1
-      if: always()
-      with:
-        webhook: ${{ secrets.DISCORD_WEBHOOK }}
-        status: ${{ job.status }}
-        title: "Android CI"
-
     - name: Send New Build Notification to Discord
       uses: sarisia/actions-status-discord@v1
       if: success()